Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOBP-840] Add payment tracking property organization_fiscal_code #6159

Merged
merged 8 commits into from
Oct 16, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Sep 5, 2024

Short description

This PR adds an additional property organization_fiscal_code for the entire payment flow mixpanel events.

List of changes proposed in this pull request

  • Added organization_fiscal_code property inside the required screens and events to track the organization fiscal code with the organization name property.

How to test

  • Executing the payment flow, you should be able to see mixpanel events with the organization fiscal code property with a value set.

@Hantex9 Hantex9 added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Sep 5, 2024
@Hantex9 Hantex9 requested a review from a team as a code owner September 5, 2024 13:38
@pagopa-github-bot pagopa-github-bot changed the title chore: [IOBP-840] Add payment tracking property organization_fiscal_code feat: [IOBP-840] Add payment tracking property organization_fiscal_code Sep 5, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 5, 2024

Affected stories

  • 🌟 IOBP-840: Pagamento in IO - Implementazione nuova event property
    subtask of
    • IOBP-769: Pagamento in IO - Tracking implementation

Generated by 🚫 dangerJS against 667a361

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.09%. Comparing base (4f204b4) to head (667a361).
Report is 603 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6159      +/-   ##
==========================================
- Coverage   48.42%   47.09%   -1.34%     
==========================================
  Files        1488     1799     +311     
  Lines       31617    36347    +4730     
  Branches     7669     8653     +984     
==========================================
+ Hits        15311    17117    +1806     
- Misses      16238    19165    +2927     
+ Partials       68       65       -3     
Files with missing lines Coverage Δ
ts/features/payments/checkout/analytics/index.ts 22.04% <ø> (ø)
...checkout/components/WalletPaymentFailureDetail.tsx 2.17% <ø> (-0.69%) ⬇️
...networking/handleWalletPaymentCreateTransaction.ts 50.00% <ø> (-26.48%) ⬇️
...ts/checkout/screens/WalletPaymentConfirmScreen.tsx 5.10% <ø> (-5.62%) ⬇️
...nts/checkout/screens/WalletPaymentDetailScreen.tsx 5.55% <ø> (-3.54%) ⬇️
...ts/checkout/screens/WalletPaymentOutcomeScreen.tsx 0.81% <ø> (-0.75%) ⬇️
...checkout/screens/WalletPaymentPickMethodScreen.tsx 1.25% <ø> (-5.06%) ⬇️
...ts/checkout/screens/WalletPaymentPickPspScreen.tsx 3.17% <ø> (-0.60%) ⬇️

... and 1405 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e7c95...667a361. Read the comment docs.

Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Hantex9 Hantex9 merged commit 17aa7c1 into master Oct 16, 2024
13 checks passed
@Hantex9 Hantex9 deleted the IOBP-840-add-tracking-properties-from-payment-flow branch October 16, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants