-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#175496403] Removed authentication and standard endpoint for health check #100
Conversation
Affected stories
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=======================================
Coverage 83.06% 83.06%
=======================================
Files 49 49
Lines 1671 1671
Branches 126 126
=======================================
Hits 1388 1388
Misses 278 278
Partials 5 5 Continue to review full report at Codecov.
|
"type": "httpTrigger", | ||
"direction": "in", | ||
"name": "req", | ||
"route": "adm/info", | ||
"route": "info", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this or is just a matter of style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need this as when the API is reachable through the API gateway we need a prefix to discriminate the target functions (backend)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is a good practice have the same standard API for all our health checks.
We need to expose info API on api management? I don't see any other info API configured on api management.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't have the need to avoid a conflict on the /info
path (read: if we don't want to expose the API though an API managament) then you can strip down the prefix
No description provided.