Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#170127598] Use the extended service model that includes metadata #13

Merged
merged 5 commits into from
Feb 12, 2020

Conversation

alexgpeppe
Copy link
Contributor

This PR aims to use the extended service model that includes also the services metadata.

@alexgpeppe
Copy link
Contributor Author

The changes depend on the 1.8.0 version of io-functions-commons, which has not been published yet. After this version is published, it's needed to update the dependency in the package.json file.

@alexgpeppe alexgpeppe changed the title [#170129433] Use the extended service model that includes metadata [#170127598] Use the extended service model that includes metadata Feb 12, 2020
@alexgpeppe alexgpeppe force-pushed the 170127598-extended-service-model-with-metadata branch from f83f04c to 6820da5 Compare February 12, 2020 11:16
serviceName: service.service_name
};
}

// Returns an API Service Metadata from an internal Service model
function getApiServiceMetadataFromRetrievedService(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toApiServiceMetadata (the "from" comes from the type of the first parameter)

retrievedService: RetrievedService
): ApiServiceMetadata {
return (
retrievedService.serviceMetadata && {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method returns the boolean "false" in case retrievedService.serviceMetadata is undefined, you should use a ternary operator here

@digitalcitizenship
Copy link

digitalcitizenship commented Feb 12, 2020

Affected stories

  • 🌟 #170127598: Come backend voglio poter salvare le informazioni sui servizi in modo che possano essere utilizzate da IO

Generated by 🚫 dangerJS

@codecov-io
Copy link

Codecov Report

Merging #13 into master will decrease coverage by 0.16%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   85.44%   85.27%   -0.17%     
==========================================
  Files           8        8              
  Lines         158      163       +5     
  Branches       10       13       +3     
==========================================
+ Hits          135      139       +4     
  Misses         23       23              
- Partials        0        1       +1
Impacted Files Coverage Δ
utils/conversions.ts 80% <80%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 083b8c7...554ebfc. Read the comment docs.

@alexgpeppe alexgpeppe marked this pull request as ready for review February 12, 2020 11:57
@gunzip gunzip merged commit 89746c1 into master Feb 12, 2020
@gunzip gunzip deleted the 170127598-extended-service-model-with-metadata branch February 12, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants