-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#170127598] Use the extended service model that includes metadata #13
[#170127598] Use the extended service model that includes metadata #13
Conversation
The changes depend on the |
f83f04c
to
6820da5
Compare
utils/conversions.ts
Outdated
serviceName: service.service_name | ||
}; | ||
} | ||
|
||
// Returns an API Service Metadata from an internal Service model | ||
function getApiServiceMetadataFromRetrievedService( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toApiServiceMetadata
(the "from" comes from the type of the first parameter)
utils/conversions.ts
Outdated
retrievedService: RetrievedService | ||
): ApiServiceMetadata { | ||
return ( | ||
retrievedService.serviceMetadata && { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this method returns the boolean "false" in case retrievedService.serviceMetadata is undefined, you should use a ternary operator here
Affected stories
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
- Coverage 85.44% 85.27% -0.17%
==========================================
Files 8 8
Lines 158 163 +5
Branches 10 13 +3
==========================================
+ Hits 135 139 +4
Misses 23 23
- Partials 0 1 +1
Continue to review full report at Codecov.
|
This PR aims to use the extended service model that includes also the services metadata.