Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IP-308] add new UserDataDeleteOrchestratorV2 #158

Merged

Conversation

gquadrati
Copy link
Contributor

@gquadrati gquadrati commented Aug 5, 2021

List of Changes

  • Added new UserDataDeleteOrchestratorV2
  • Added new GetServicesPreferencesActivity
  • Modified UpdateSubscriptionFeedActivity
  • Modified trigger to call new UserDataDeleteOrchestratorV2

Motivation and Context

In order to proper manage the subscription feed with new services preferences settings, we need to change the UserDataDeleteOrchestratorV2

How Has This Been Tested?

  • Unit tests
  • iomock

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

@gquadrati gquadrati changed the title [#IP-308] [#IP-308] add new UserDataDeleteOrchestratorV2 [#IP-308] add new UserDataDeleteOrchestratorV2 Aug 5, 2021
@gquadrati gquadrati marked this pull request as ready for review August 6, 2021 10:19
Copy link
Contributor

@AleDore AleDore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since both UserDataDeleteOrchestrator versions share the same code for utility functions such as getProfile or setUserSessionLock or whatever else, can we try to resume these functions in a separate file in order to keep orchestrator logic clean in handlers?

@gquadrati
Copy link
Contributor Author

Since both UserDataDeleteOrchestrator versions share the same code for utility functions such as getProfile or setUserSessionLock or whatever else, can we try to resume these functions in a separate file in order to keep orchestrator logic clean in handlers?

UserDataDeleteOrchestrator is not used anymore. We are keeping it, as we did in fn-app, just in case of need to switch back.
Since we're gonna delete it as soon as we are confident, do you think it's necessary this refactoring?

@AleDore
Copy link
Contributor

AleDore commented Aug 9, 2021

Since both UserDataDeleteOrchestrator versions share the same code for utility functions such as getProfile or setUserSessionLock or whatever else, can we try to resume these functions in a separate file in order to keep orchestrator logic clean in handlers?

UserDataDeleteOrchestrator is not used anymore. We are keeping it, as we did in fn-app, just in case of need to switch back.
Since we're gonna delete it as soon as we are confident, do you think it's necessary this refactoring?

Maybe it's unnecessary you're right :)

@fabriziopapi fabriziopapi merged commit 2339140 into master Aug 9, 2021
@fabriziopapi fabriziopapi deleted the IP-308--fix-subscription-feed-on-changemodetest branch August 9, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants