Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IP-417] Fix healthcheck stage #168

Merged
merged 2 commits into from
Sep 30, 2021
Merged

[#IP-417] Fix healthcheck stage #168

merged 2 commits into from
Sep 30, 2021

Conversation

gquadrati
Copy link
Contributor

List of Changes

  • Upgrade azure devops templates ref to v17
  • New healthcheck management

Motivation and Context

Fix healthcheck

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gquadrati gquadrati requested a review from a team as a code owner September 29, 2021 10:07
@gquadrati gquadrati requested review from infantesimone, LoFrance, michaeldisaro and balanza and removed request for a team September 29, 2021 10:07
@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

michaeldisaro
michaeldisaro approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@michaeldisaro michaeldisaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gquadrati gquadrati merged commit 757300e into master Sep 30, 2021
@gquadrati gquadrati deleted the ip-417--fix-healthcheck branch September 30, 2021 09:06
infantesimone
infantesimone reviewed Sep 30, 2021
View reviewed changes
.devops/deploy-pipelines.yml
- checkout: none
- script: |
# fails if response status is not 2xx
curl -f 'https://$(PRODUCTION_APP_NAME)-staging.azurewebsites.net/$(HEALTHCHECK_PATH)'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sound good 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infantesimone infantesimone infantesimone left review comments

@michaeldisaro michaeldisaro michaeldisaro approved these changes

@LoFrance LoFrance Awaiting requested review from LoFrance

@balanza balanza Awaiting requested review from balanza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gquadrati @pagopa-github-bot @michaeldisaro @infantesimone