Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-1030] Added delete profileEmail logic to DeleteUserDataActivity #229

Merged
merged 14 commits into from
Jan 23, 2024
Merged

[#IOPID-1030] Added delete profileEmail logic to DeleteUserDataActivity #229

merged 14 commits into from
Jan 23, 2024

Conversation

silvicir
Copy link
Contributor

@silvicir silvicir commented Jan 18, 2024 •
edited
Loading

List of Changes

Updated DeleteUserDataActivity function with the cancellation of profileEmails entity as last operation

Motivation and Context

Now we have the profileEmails table storage populated with the validated email for each fiscal code. When a user requires their data deletion, the respective entity must be cancelled from the profileEmails. Then the email can be selected and validated again by someone else.

How Has This Been Tested?

Through unit tests and io-mock

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1030

@silvicir silvicir marked this pull request as ready for review January 22, 2024 11:30
@silvicir silvicir requested a review from a team as a code owner January 22, 2024 11:30
@silvicir silvicir requested review from grausof, drmarro, gquadrati, lucacavallaro, BurnedMarshal and arcogabbo and removed request for a team January 22, 2024 11:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.9% Duplication on New Code

See analysis details on SonarCloud

gquadrati
gquadrati approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@silvicir silvicir merged commit 602a2a1 into master Jan 23, 2024
4 checks passed
@silvicir silvicir deleted the IOPID-1030-delete-user-data branch January 23, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gquadrati gquadrati gquadrati approved these changes

@grausof grausof Awaiting requested review from grausof grausof is a code owner automatically assigned from pagopa/io-backend-contributors

@drmarro drmarro Awaiting requested review from drmarro drmarro is a code owner automatically assigned from pagopa/io-backend-contributors

@lucacavallaro lucacavallaro Awaiting requested review from lucacavallaro

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal

@arcogabbo arcogabbo Awaiting requested review from arcogabbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silvicir @gquadrati @lucacavallaro @pagopa-github-bot