Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOPID-2503] add masking preprocessor for appinsights #248

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

arcogabbo
Copy link
Contributor

List of Changes

Motivation and Context

added preprocessor capability to applicationinsights

How Has This Been Tested?

local run

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

github-actions bot commented Nov 25, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-2503

Comment on lines +30 to +31
userDataProcessingId !== undefined &&
typeof userDataProcessingId === "string"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we use FiscalCode.is instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the ID include the operation type, is not a plain CF

@arcogabbo arcogabbo marked this pull request as ready for review November 25, 2024 15:59
@arcogabbo arcogabbo requested a review from a team as a code owner November 25, 2024 15:59
@arcogabbo arcogabbo requested review from rodoviti and gquadrati and removed request for a team November 25, 2024 15:59
@arcogabbo arcogabbo merged commit 7b41c9d into master Nov 25, 2024
5 checks passed
@arcogabbo arcogabbo deleted the IOPID-2503--add-ai-preprocessor branch November 25, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants