-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#171405596] Add function to create a subscription for a specific user #25
Conversation
a658268
to
6b48dc9
Compare
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 86.95% 86.93% -0.03%
==========================================
Files 17 20 +3
Lines 437 505 +68
Branches 30 30
==========================================
+ Hits 380 439 +59
- Misses 56 65 +9
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm so far
"IResponseErrorValidation", | ||
readonly [EmailAddress, NonEmptyString] | ||
> = request => | ||
sequenceT(taskEither)( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
utils/middlewares/productName.ts
Outdated
@@ -0,0 +1,16 @@ | |||
import { IRequestMiddleware } from "italia-ts-commons/lib/request_middleware"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to remove this middleware and just use https://github.com/pagopa/io-functions-commons/blob/master/src/utils/middlewares/required_body_payload.ts#L13
RequiredBodyMiddleware(ProductNamePayload)
in the handler
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
+ Coverage 86.95% 87.05% +0.09%
==========================================
Files 17 19 +2
Lines 437 502 +65
Branches 30 30
==========================================
+ Hits 380 437 +57
- Misses 56 64 +8
Partials 1 1
Continue to review full report at Codecov.
|
This PR aims to add a function to create a subscription for a user.