Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#171405596] Add function to create a subscription for a specific user #25

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

alexgpeppe
Copy link
Contributor

This PR aims to add a function to create a subscription for a user.

@alexgpeppe alexgpeppe force-pushed the 171405596-create-sbuscription branch from a658268 to 6b48dc9 Compare March 4, 2020 10:52
@codecov-io
Copy link

Codecov Report

Merging #25 into master will decrease coverage by 0.02%.
The diff coverage is 86.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   86.95%   86.93%   -0.03%     
==========================================
  Files          17       20       +3     
  Lines         437      505      +68     
  Branches       30       30              
==========================================
+ Hits          380      439      +59     
- Misses         56       65       +9     
  Partials        1        1
Impacted Files Coverage Δ
.../middlewares/createSubscriptionParamsMiddleware.ts 70% <70%> (ø)
utils/middlewares/productName.ts 75% <75%> (ø)
CreateSubscription/handler.ts 90.74% <90.74%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cdeb6f...6b48dc9. Read the comment docs.

Copy link
Contributor

@gunzip gunzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm so far

"IResponseErrorValidation",
readonly [EmailAddress, NonEmptyString]
> = request =>
sequenceT(taskEither)(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@alexgpeppe alexgpeppe marked this pull request as ready for review March 4, 2020 16:26
@@ -0,0 +1,16 @@
import { IRequestMiddleware } from "italia-ts-commons/lib/request_middleware";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to remove this middleware and just use https://github.com/pagopa/io-functions-commons/blob/master/src/utils/middlewares/required_body_payload.ts#L13

RequiredBodyMiddleware(ProductNamePayload) in the handler

@alexgpeppe alexgpeppe requested a review from gunzip March 5, 2020 08:56
@BurnedMarshal
Copy link
Contributor

Codecov Report

Merging #25 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   86.95%   87.05%   +0.09%     
==========================================
  Files          17       19       +2     
  Lines         437      502      +65     
  Branches       30       30              
==========================================
+ Hits          380      437      +57     
- Misses         56       64       +8     
  Partials        1        1              
Impacted Files Coverage Δ
.../middlewares/createSubscriptionParamsMiddleware.ts 70.00% <0.00%> (ø)
CreateSubscription/handler.ts 90.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cdeb6f...7fd1815. Read the comment docs.

@gunzip gunzip merged commit e3d47fb into master Mar 5, 2020
@gunzip gunzip deleted the 171405596-create-sbuscription branch March 5, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants