Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#171549167] Add function to update the group list of a specific user #28

Merged
merged 11 commits into from
Mar 10, 2020

Conversation

alexgpeppe
Copy link
Contributor

This PR aims to add a function to edit the list of groups associated with a specific user from the API management.

@alexgpeppe alexgpeppe force-pushed the 171549167-update-user-groups branch from ed50232 to 56bda98 Compare March 9, 2020 14:05
Copy link
Contributor

@gunzip gunzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good !

UpdateUserGroups/handler.ts Outdated Show resolved Hide resolved
UpdateUserGroups/handler.ts Show resolved Hide resolved
UpdateUserGroups/handler.ts Show resolved Hide resolved
UpdateUserGroups/handler.ts Outdated Show resolved Hide resolved
@BurnedMarshal
Copy link
Contributor

Codecov Report

Merging #28 into master will increase coverage by 0.79%.
The diff coverage is 92.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   87.07%   87.87%   +0.79%     
==========================================
  Files          19       20       +1     
  Lines         503      602      +99     
  Branches       30       36       +6     
==========================================
+ Hits          438      529      +91     
- Misses         64       72       +8     
  Partials        1        1              
Impacted Files Coverage Δ
GetUser/handler.ts 91.17% <ø> (-1.23%) ⬇️
UpdateUserGroups/handler.ts 91.83% <91.83%> (ø)
utils/apim.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1edb07...113e0f0. Read the comment docs.

@alexgpeppe alexgpeppe force-pushed the 171549167-update-user-groups branch from 113e0f0 to 263bb26 Compare March 10, 2020 11:57
@alexgpeppe alexgpeppe marked this pull request as ready for review March 10, 2020 11:58
@codecov-io
Copy link

Codecov Report

Merging #28 into master will increase coverage by 0.81%.
The diff coverage is 92.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   86.95%   87.76%   +0.81%     
==========================================
  Files          19       20       +1     
  Lines         506      605      +99     
  Branches       31       37       +6     
==========================================
+ Hits          440      531      +91     
- Misses         65       73       +8     
  Partials        1        1
Impacted Files Coverage Δ
GetUser/handler.ts 91.17% <ø> (-1.23%) ⬇️
utils/apim.ts 100% <100%> (ø) ⬆️
UpdateUserGroups/handler.ts 91.83% <91.83%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b108183...61151b1. Read the comment docs.

@gunzip gunzip self-requested a review March 10, 2020 12:42
@gunzip gunzip merged commit f58afa4 into master Mar 10, 2020
@gunzip gunzip deleted the 171549167-update-user-groups branch March 10, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants