[#172621882] small refactor: generate zip with user data #45
Conversation
gunzip
commented
May 15, 2020
•
gunzip
commented
- removed useless code in zip module
- removed useless code in random module
- removed a wrong test
gunzip
changed the title
Affected stories
New dependencies added: @types/archiverAuthor: Unknown Description: TypeScript definitions for archiver Homepage: http://npmjs.com/package/@types/archiver
|
| Created | almost 4 years ago |
| Last Updated | 16 days ago |
| License | MIT |
| Maintainers | 1 |
| Releases | 6 |
| Direct Dependencies |
README
Installation
npm install --save @types/randomstring
Summary
This package contains type definitions for randomstring (https://github.com/klughammer/node-randomstring).
Details
Files were exported from https://www.github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/randomstring
Additional Details
- Last updated: Fri, 16 Jun 2017 16:37:51 GMT
- Dependencies: none
- Global values: Randomstring
Credits
These definitions were written by Isman Usoh https://github.com/isman-usoh/.
Generated by 🚫 dangerJS
| await handler(contextMock, input); | ||
|
|
||
| // @ts-ignore as | ||
| const mockCall = createCompressedStream.mock.calls[0]; |
There was a problem hiding this comment.
this is wrong and we must rewrite it. if you mock the blobService and call cb() immediately the code following createWriteStreamToBlockBlob won't never be executed
| Object.entries(data).forEach(([fileName, content]) => { | ||
| zipArchive.append(JSON.stringify(content), { name: fileName }); | ||
| }); | ||
| zipArchive.finalize(); |
There was a problem hiding this comment.
this is a promise and must be awaited somewhere
