-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#172621882] send a message to the user that requested her own data #50
Conversation
Affected stories
New dependencies added: ts-nodeAuthor: Blake Embrey Description: TypeScript execution environment and REPL for node.js, with source map support Homepage: https://github.com/TypeStrong/ts-node
Generated by 🚫 dangerJS |
@@ -583,5 +580,6 @@ export function createExtractUserDataActivityHandler( | |||
value: archiveInfo | |||
}) | |||
) | |||
.run(); | |||
.run() | |||
.then(e => e.value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you cannot return an Either from an activity since the return value must be serializable (that's the reason we have ActivityResultSuccess / Failure)
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
- Coverage 88.81% 86.26% -2.56%
==========================================
Files 21 25 +4
Lines 608 808 +200
Branches 37 50 +13
==========================================
+ Hits 540 697 +157
- Misses 67 110 +43
Partials 1 1
Continue to review full report at Codecov.
|
draft as test must be refactored to handle promises (return value from activities) instead of taskeithers