Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#172621882] send a message to the user that requested her own data #50

Merged
merged 9 commits into from
May 17, 2020

Conversation

gunzip
Copy link
Contributor

@gunzip gunzip commented May 17, 2020

draft as test must be refactored to handle promises (return value from activities) instead of taskeithers

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented May 17, 2020

Affected stories

  • 🌟 #172621882: Come CIT, quando esprimo la volontà di scaricare i miei dati, voglio ricevere un link per il download dei dati entro 7gg dalla richiesta

New dependencies added: ts-node.

ts-node

Author: Blake Embrey

Description: TypeScript execution environment and REPL for node.js, with source map support

Homepage: https://github.com/TypeStrong/ts-node

Createdover 4 years ago
Last Updated15 days ago
LicenseMIT
Maintainers2
Releases107
Direct Dependenciesarg, diff, make-error, source-map-support and yn
Keywordstypescript, node, runtime, environment, ts and compiler
This README is too long to show.

Generated by 🚫 dangerJS

@@ -583,5 +580,6 @@ export function createExtractUserDataActivityHandler(
value: archiveInfo
})
)
.run();
.run()
.then(e => e.value);
Copy link
Contributor Author

@gunzip gunzip May 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot return an Either from an activity since the return value must be serializable (that's the reason we have ActivityResultSuccess / Failure)

@gunzip gunzip marked this pull request as draft May 17, 2020 15:27
@gunzip gunzip requested a review from balanza May 17, 2020 15:28
@gunzip gunzip changed the title add message sending to cli [#172621882] add message sending to cli May 17, 2020
@gunzip gunzip changed the title [#172621882] add message sending to cli [#172621882] send a message to the user that requested her own data May 17, 2020
@codecov-io
Copy link

codecov-io commented May 17, 2020

Codecov Report

Merging #50 into master will decrease coverage by 2.55%.
The diff coverage is 77.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   88.81%   86.26%   -2.56%     
==========================================
  Files          21       25       +4     
  Lines         608      808     +200     
  Branches       37       50      +13     
==========================================
+ Hits          540      697     +157     
- Misses         67      110      +43     
  Partials        1        1              
Impacted Files Coverage Δ
CreateService/handler.ts 85.18% <0.00%> (ø)
UpdateService/handler.ts 90.47% <0.00%> (ø)
GetService/handler.ts 86.95% <50.00%> (+3.62%) ⬆️
utils/zip.ts 53.33% <53.33%> (ø)
ExtractUserDataActivity/handler.ts 77.61% <77.61%> (ø)
utils/random.ts 77.77% <77.77%> (ø)
SetUserDataProcessingStatusActivity/handler.ts 88.37% <88.37%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548a9ed...fb7167b. Read the comment docs.

@gunzip gunzip marked this pull request as ready for review May 17, 2020 20:55
@gunzip gunzip merged commit 2fa9b2c into master May 17, 2020
@gunzip gunzip deleted the send-user-data-message branch May 17, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants