[#174850132] Prevent errors on missing notification #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
- Coverage 86.62% 85.10% -1.53%
==========================================
Files 39 41 +2
Lines 1249 1363 +114
Branches 88 114 +26
==========================================
+ Hits 1082 1160 +78
- Misses 166 198 +32
- Partials 1 5 +4
Continue to review full report at Codecov.
|
Affected stories
Generated by 🚫 dangerJS |
gunzip
reviewed
Sep 17, 2020
ExtractUserDataActivity/handler.ts
Outdated
| ) | ||
| ) | ||
| ); | ||
| .map(arrayOfMabeNotifications => | ||
| arrayOfMabeNotifications |
There was a problem hiding this comment.
you can use array.catOptions === filter(isSome) + x.value
https://github.com/gcanti/fp-ts/blob/1.17.4/src/Array.ts#L1312
gunzip
reviewed
Sep 17, 2020
ExtractUserDataActivity/handler.ts
Outdated
| ) | ||
| ) | ||
| ); | ||
| .map(arrayOfMabeNotifications => |
There was a problem hiding this comment.
Suggested change
| .map(arrayOfMabeNotifications => | |
| .map(array.catOptions) => |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves a bug for which, when a user request his/her data to be downloaded, if he/she has at leas one message with no related notification (this case is legal) the request fails.