Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#175170499] Add missing unauthorized to openapi specs #91

Merged
merged 2 commits into from
Oct 7, 2020
Merged

[#175170499] Add missing unauthorized to openapi specs #91

merged 2 commits into from
Oct 7, 2020

Conversation

AleDore
Copy link
Contributor

@AleDore AleDore commented Oct 7, 2020

This PR adds missing unauthorized response to operations that could return 401, with focus on GetUser and CreateSubscription

@pagopa-github-bot
Copy link
Contributor

Affected stories

  • 🌟 #175170499: Come SAS, vorrei che richiamando le API esposte da io-functions-admin senza corretta autenticazione, mi venga restituito 401 (Unauthorized)

Generated by 🚫 dangerJS

gunzip
gunzip approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@gunzip gunzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @AleDore ! kudos to @balanza as the generated clients are helping us fixing broken specs :-D

@gunzip gunzip merged commit 33442c2 into master Oct 7, 2020
@gunzip gunzip deleted the add_unauthorized_to_specs branch October 7, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunzip gunzip gunzip approved these changes

@balanza balanza Awaiting requested review from balanza

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal

@francescopersico francescopersico Awaiting requested review from francescopersico

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AleDore @pagopa-github-bot @gunzip