Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove containerName from ServicesPreferencesModel #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove containerName from ServicesPreferencesModel #187

wants to merge 1 commit into from

Conversation

BurnedMarshal
Copy link
Contributor

The value of containerName in ServicesPreferencesModel constructor is unused and it was removed.

List of Changes

Remove containerName from constructor of ServicesPreferencesModel

Motivation and Context

The value of containerName in ServicesPreferencesModel constructor is unused and can be removed.

How Has This Been Tested?

unit test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against 03736f7

@balanza
Copy link
Contributor

balanza commented Sep 13, 2021

Why draft?

@BurnedMarshal BurnedMarshal marked this pull request as ready for review September 13, 2021 07:58
@BurnedMarshal
Copy link
Contributor Author

Why draft?

Draft removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BurnedMarshal @pagopa-github-bot @balanza