[#IC-351] Wrap SDK Cosmos as functional (CRUD + Patch) #243
Conversation
Example of PR titles that include pivotal stories:
|
There was a problem hiding this comment.
I see a lot of rewriting/duplication here. What's the need that motivated such work? If you looked for composability, I propose two alternative ways:
a) Wrap an instance over a method
Basically, create an instance for every method invocation and return the method itself
const create = (/* model constructor params */) => {
const instance = new CosmosdbModel(/* model constructor params */)
return CosmosdbModel.prototype.create.bind(instance)
}b) Refactor cosmosdb_model with a RoRo/Module pattern
Instead of creating instances of a class, return a plain object with what you would call "public methods"
const createCosmosdbModel = (/* model constructor params */) => {
const privateMethodA = () => /**/
const privateMethodB = () => /**/
return {
create(newDocument) { /* */ },
upsert(newDocument) { /* */ },
/* other methods */
}
}
const { create } = CosmosdbModel(/* */) // create is now a composable method
|
the RoRo/Module is really an intersting solution. I'll try to rework with it. |
Anyway, solution |
Allow cosmos SDK to be used as functional programming (fp-ts style). Cover the CRUD and PATCH (partial update) operations for not versioned model.
List of Changes
Add CRUD wrapper
Add PATCH wrapper
Add propertiesToArray function to flat a nested object
Motivation and Context
We need all the object to perofmr and update (or upsert) operation on cosmos collection. With the wrapper we can modify a single collection field without knowning the entire document. The operations will be callable directly from a pipe or a flow.
How Has This Been Tested?
unit tests
Screenshots (if appropriate):
Types of changes
Checklist: