Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOCOM-1030] Extract userId from NewRCConfigurationBase #361

Merged
merged 2 commits into from
Feb 6, 2024
Merged

[IOCOM-1030] Extract userId from NewRCConfigurationBase #361

merged 2 commits into from
Feb 6, 2024

Conversation

Garma00
Copy link
Contributor

@Garma00 Garma00 commented Feb 5, 2024

We need this property to be outside of NewRCConfigurationBase in order to manage operations of create and update

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Garma00
Extract userId from NewRCConfigurationBase
bb5e835 
We need this property to be outside of NewRCConfigurationBase in order to manage operations of create and update
@Garma00 Garma00 requested a review from a team as a code owner February 5, 2024 17:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-1030

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

acuiuli
acuiuli approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@acuiuli acuiuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Garma00 Garma00 merged commit 04d5b98 into master Feb 6, 2024
5 checks passed
@Garma00 Garma00 deleted the IOCOM-1030 branch February 6, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acuiuli acuiuli acuiuli approved these changes

@lucacavallaro lucacavallaro Awaiting requested review from lucacavallaro lucacavallaro is a code owner automatically assigned from pagopa/io-backend-contributors

@giuseppedipinto giuseppedipinto Awaiting requested review from giuseppedipinto giuseppedipinto is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Garma00 @acuiuli