Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOCOM-1036] Added UserRCConfig model to bind users to rc configurations #363

Merged
merged 5 commits into from
Feb 27, 2024
Merged

[#IOCOM-1036] Added UserRCConfig model to bind users to rc configurations #363

merged 5 commits into from
Feb 27, 2024

Conversation

michaeldisaro
Copy link
Contributor

List of Changes

Added UserRCConfig model

Motivation and Context

We need to bind users to rc configurations to avoid expensive cross partition queries during rc config list by userId.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@michaeldisaro michaeldisaro requested a review from a team as a code owner February 7, 2024 17:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-1036

Garma00
Garma00 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@Garma00 Garma00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm apart of the linter and a little observation

src/models/user_rc_configuration.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@michaeldisaro
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@michaeldisaro michaeldisaro merged commit 10b8369 into master Feb 27, 2024
5 checks passed
@michaeldisaro michaeldisaro deleted the iocom-1036 branch February 27, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacavallaro lucacavallaro lucacavallaro left review comments

@Garma00 Garma00 Garma00 approved these changes

@drmarro drmarro Awaiting requested review from drmarro drmarro is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaeldisaro @lucacavallaro @Garma00