Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncIterable depends on AsyncIterator utils, remove useless reduceAsyncIterator #84

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

BurnedMarshal
Copy link
Contributor

This PR resolve the pending change requests on PR #82

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against 9633ffc

@codecov-commenter
Copy link

Codecov Report

Merging #84 into master will decrease coverage by 3.28%.
The diff coverage is 79.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   86.50%   83.21%   -3.29%     
==========================================
  Files          32       33       +1     
  Lines        1000      840     -160     
  Branches       92       83       -9     
==========================================
- Hits          865      699     -166     
- Misses        133      138       +5     
- Partials        2        3       +1     
Impacted Files Coverage Δ
src/utils/response.ts 50.00% <50.00%> (+8.82%) ⬆️
src/utils/async.ts 52.72% <52.72%> (ø)
src/models/message.ts 84.84% <73.52%> (-4.86%) ⬇️
src/models/message_status.ts 85.00% <75.00%> (-0.30%) ⬇️
src/models/notification_status.ts 81.25% <80.00%> (-0.98%) ⬇️
src/utils/cosmosdb_model_versioned.ts 84.44% <84.44%> (ø)
src/utils/cosmosdb_model.ts 85.24% <85.24%> (ø)
src/utils/mailup.ts 90.47% <85.71%> (-1.33%) ⬇️
src/utils/types.ts 90.90% <90.90%> (ø)
src/utils/multi_transport_connection.ts 95.23% <95.23%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11604ca...9633ffc. Read the comment docs.

@BurnedMarshal BurnedMarshal requested a review from cloudify July 30, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants