Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing pk in find() #95

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Fix missing pk in find() #95

merged 2 commits into from
Aug 10, 2020

Conversation

BurnedMarshal
Copy link
Contributor

No description provided.

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).
⚠️ Please include a description of your PR changes.

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against 88ea6a4

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2020

Codecov Report

Merging #95 into master will decrease coverage by 1.96%.
The diff coverage is 83.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   86.50%   84.53%   -1.97%     
==========================================
  Files          32       33       +1     
  Lines        1000      847     -153     
  Branches       92       89       -3     
==========================================
- Hits          865      716     -149     
+ Misses        133      128       -5     
- Partials        2        3       +1     
Impacted Files Coverage Δ
src/utils/response.ts 50.00% <50.00%> (+8.82%) ⬆️
src/utils/async.ts 63.46% <63.46%> (ø)
src/models/message.ts 86.15% <77.14%> (-3.56%) ⬇️
src/models/message_status.ts 84.21% <77.77%> (-1.09%) ⬇️
src/models/notification_status.ts 80.64% <81.81%> (-1.58%) ⬇️
src/utils/cosmosdb_model.ts 85.71% <85.71%> (ø)
src/utils/mailup.ts 90.47% <85.71%> (-1.33%) ⬇️
src/utils/cosmosdb_model_versioned.ts 86.79% <86.79%> (ø)
src/utils/types.ts 90.90% <90.90%> (ø)
src/utils/multi_transport_connection.ts 95.23% <95.23%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b51dd3...88ea6a4. Read the comment docs.

@BurnedMarshal BurnedMarshal changed the title Fix missing pk find Fix missing pk in find() Aug 10, 2020
@gunzip gunzip merged commit 460557c into master Aug 10, 2020
balanza pushed a commit that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants