Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CES-460] Added new storage account iopsteucovidcert for ITN migration #1280

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

cfcuffari120400
Copy link
Collaborator

@cfcuffari120400 cfcuffari120400 commented Nov 5, 2024

Motivation and Context

Storage accounts must be replicated to italy north in view of the infrastructure migration

Major Changes

Create replication of iopsteucovidcert in italy north

Dependencies

Testing

Documentation

Other Considerations

Copy link

github-actions bot commented Nov 5, 2024

Terraform Plan ('src/domains/eucovidcert/prod/westeurope') 📖

Terraform Plan
::error::Terraform exited with code 1.

@FasanoBip
Copy link

@christian-calabrese I didn’t set up any action group, even though there were two in the equivalent storage in westeurope, because you mentioned they are no longer needed.

@FasanoBip FasanoBip changed the title CES-460-migrate-iopsteucovidcert new module code [CES-460] Added new storage account iopsteucovidcert for ITN migration Nov 8, 2024
Copy link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use data inside a child module, but in the main one and then use variables to pass values along

subservices_enabled = {
blob = false
file = false
queue = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no private endpoint enabled for queues

Suggested change
queue = true
queue = false

blob = false
file = false
queue = true
table = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no private endpoint enabled for tables

Suggested change
table = true
table = false

@Krusty93 Krusty93 marked this pull request as ready for review December 10, 2024 09:01
@Krusty93 Krusty93 requested review from a team as code owners December 10, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants