Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOCIT-176] porting Function Admin v4 #315

Merged
merged 21 commits into from
Dec 28, 2022
Merged

Conversation

BurnedMarshal
Copy link
Contributor

List of changes

Create a new function-admin with Azure Function v4 runtime
Remove some duplicated configuration

Motivation and context

Create a new functions-admin porting the function admin from io-infrastructure-live-new with Azure Function v4 runtime.

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

  1. run deploy pipeline from Azure DevOps io-platform-iac-projects
  2. select PR branch
  3. wait for approval

src/core/function_admin.tf Outdated Show resolved Hide resolved
src/core/function_admin.tf Outdated Show resolved Hide resolved
@arcogabbo arcogabbo mentioned this pull request Dec 6, 2022
10 tasks
Copy link
Member

@pasqualedevita pasqualedevita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after this change we can merge

src/core/function_admin.tf Outdated Show resolved Hide resolved
michaeldisaro
michaeldisaro previously approved these changes Dec 16, 2022
Copy link
Contributor

@michaeldisaro michaeldisaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart a couple questions LGTM

src/core/99_locals.tf Show resolved Hide resolved
src/core/app_messages.tf Show resolved Hide resolved
pasqualedevita
pasqualedevita previously approved these changes Dec 23, 2022
src/core/function_admin.tf Outdated Show resolved Hide resolved
src/core/function_admin.tf Outdated Show resolved Hide resolved

## Alerts

resource "azurerm_monitor_metric_alert" "function_admin_health_check" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 69837b0

michaeldisaro and others added 6 commits December 27, 2022 13:44
Co-authored-by: Pasquale De Vita <59291437+pasqualedevita@users.noreply.github.com>
Co-authored-by: Pasquale De Vita <59291437+pasqualedevita@users.noreply.github.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@michaeldisaro michaeldisaro merged commit b3137a5 into main Dec 28, 2022
@michaeldisaro michaeldisaro deleted the IOCIT-176-fn-admin branch December 28, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants