-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#IOCIT-176] porting Function Admin v4 #315
Conversation
c57c554
to
3570044
Compare
ff06adc
to
a8d02c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after this change we can merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart a couple questions LGTM
Co-authored-by: Pasquale De Vita <59291437+pasqualedevita@users.noreply.github.com>
d4e6014
to
81a5544
Compare
src/core/function_admin.tf
Outdated
|
||
## Alerts | ||
|
||
resource "azurerm_monitor_metric_alert" "function_admin_health_check" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 69837b0
Co-authored-by: Pasquale De Vita <59291437+pasqualedevita@users.noreply.github.com>
Co-authored-by: Pasquale De Vita <59291437+pasqualedevita@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
List of changes
Create a new
function-admin
with Azure Function v4 runtimeRemove some duplicated configuration
Motivation and context
Create a new
functions-admin
porting the function admin fromio-infrastructure-live-new
with Azure Function v4 runtime.Type of changes
Env to apply
Does this introduce a change to production resources with possible user impact?
Does this introduce an unwanted change on infrastructure? Check terraform plan execution result
Other information
If PR is partially applied, why? (reserved to mantainers)
How to apply
After PR is approved