Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added FIMS endpoint #863

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Added FIMS endpoint #863

merged 1 commit into from
Feb 7, 2024

Conversation

michaeldisaro
Copy link
Contributor

@michaeldisaro michaeldisaro commented Feb 7, 2024 •
edited
Loading

List of changes

Motivation and context

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information

If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

  1. run deploy pipeline from Azure DevOps io-platform-iac-projects
  2. select PR branch
  3. wait for approval

@michaeldisaro michaeldisaro requested review from a team as code owners February 7, 2024 17:38
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

acuiuli
acuiuli approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@acuiuli acuiuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@michaeldisaro michaeldisaro merged commit 647c4f5 into main Feb 7, 2024
6 checks passed
@michaeldisaro michaeldisaro deleted the added-fims-public-endpoint-1 branch February 7, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acuiuli acuiuli acuiuli approved these changes

@francescopersico francescopersico Awaiting requested review from francescopersico francescopersico is a code owner automatically assigned from pagopa/io-backend-contributors

@pasqualedevita pasqualedevita Awaiting requested review from pasqualedevita pasqualedevita is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeldisaro @acuiuli