Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAS-1146] feat: Added property "primitive_version" to Channel class #306

Merged
merged 5 commits into from
Jul 10, 2024
Merged

[VAS-1146] feat: Added property "primitive_version" to Channel class #306

merged 5 commits into from
Jul 10, 2024

Conversation

svariant
Copy link
Collaborator

@svariant svariant commented Jul 9, 2024 •
edited by jira bot
Loading

List of Changes

  • Added property "primitive_version" to Channel class
  • Updated unit tests

Motivation and Context

VAS-1146

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@svariant svariant added the minor label Jul 9, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@svariant svariant enabled auto-merge July 10, 2024 13:28
gioelemella
gioelemella approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@gioelemella gioelemella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@svariant svariant merged commit 394a98e into main Jul 10, 2024
5 checks passed
@svariant svariant deleted the VAS-1146-primitive-version-channel branch July 10, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioelemella gioelemella gioelemella approved these changes

@jacopocarlini jacopocarlini Awaiting requested review from jacopocarlini

Assignees

@svariant svariant

Labels
minor size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svariant @gioelemella @pagopa-github-bot