Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [PAGOPA-1882] receipt PDF Generation even in the absence of the payer's name and surname #129

Merged
merged 1 commit into from
Jun 26, 2024
Merged

feat: [PAGOPA-1882] receipt PDF Generation even in the absence of the payer's name and surname #129

merged 1 commit into from
Jun 26, 2024

Conversation

alessio-acitelli
Copy link
Collaborator

@alessio-acitelli alessio-acitelli commented Jun 26, 2024 •
edited
Loading

List of Changes

  • deleted exception and replaced with blank

Motivation and Context

  • error during PDF generation in case of missing payer's name and surname

How Has This Been Tested?

  • junit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

[PAGOPA-1882] full name:
7c45219 
returns "" and junit test
@github-actions GitHub Actions
Copy link

This pull request does not contain a valid label. Please add one of the following labels: [patch, minor, major, skip]

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alessio-acitelli alessio-acitelli marked this pull request as ready for review June 26, 2024 13:19
pasqualespica
pasqualespica approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pasqualespica pasqualespica merged commit 67cfaa4 into main Jun 26, 2024
15 of 20 checks passed
@github-actions GitHub Actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-acitelli alessio-acitelli

Labels
patch size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessio-acitelli @pasqualespica