Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRDP-70] feat: New single template implementation #14

Merged
merged 218 commits into from
Oct 4, 2023
Merged

[PRDP-70] feat: New single template implementation #14

merged 218 commits into from
Oct 4, 2023

Conversation

svariant
Copy link
Collaborator

@svariant svariant commented Sep 22, 2023 •
edited by gioelemella
Loading

List of Changes

  • Deleted old double templates' zips
  • Added new single dynamic template zip
  • Deleted old double template logic
  • Avoid to requeue the message when the generation ended with FAILED status or has reached max retry
  • Refactor logic for PDF receipt generation and save on Blob Storage

Motivation and Context

Issue PRDP-70

How Has This Been Tested?

Run unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@svariant svariant added the enhancement New feature or request label Sep 22, 2023
@svariant svariant self-assigned this Sep 22, 2023
@pasqualespica pasqualespica marked this pull request as ready for review October 4, 2023 09:22
svariant and others added 14 commits October 4, 2023 11:24
@svariant
[PRDP-70] Deleted old templates - added new template
f26c3c8
@svariant
[PRDP-70] Deleted old double template logic
0e84df6
@svariant
[PRDP-70] added pdf template models
d666702
@svariant
[PRDP-70] refactor GenerateReceiptProcess function
b44691d
@svariant
[PRDP-70] remove useless list from output binding and avoid message r…
6e63065 
…equeue when debtor's CF is null
@svariant
[PRDP-70] fix unit tests and log
883a242
@svariant
[PRDP-70] added unit tests
0f4b351
@svariant
[PRDP-70] refactor GenerateReceiptPdfService logic and fixed requeue …
1928f10 
…of message. Implemented logic to build receipt template data
@svariant
[PRDP-70] update javadoc
2342675
@svariant
[PRDP-70] fix constructor visibility and unit test package
9aff64e
@svariant
[PRDP-70] removed useless class and variables and improved exception …
3bc804b 
…handling. Fix unit tests
@svariant
[PRDP-70] removed useless file
536c168
@svariant
[PRDP-70] Updated complete/partial template logic - bizEvent to templ…
3dca7f4 
…ate mapping
@svariant
Merge remote-tracking branch 'origin/PRDP-70-single-template-implemen…
ccc83e8 
…tation' into PRDP-70-single-template-implementation
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

73.7% 73.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@pasqualespica pasqualespica merged commit 2b40720 into main Oct 4, 2023
7 of 11 checks passed
@pasqualespica pasqualespica temporarily deployed to dev October 4, 2023 09:32 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to dev October 4, 2023 09:38 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@svariant svariant

Labels
enhancement New feature or request minor size/large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@svariant @pasqualespica @gioelemella @pagopa-github-bot @alessio-cialini