Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRDP-145] feat add logo management #21

Merged
merged 50 commits into from
Oct 16, 2023
Merged

[PRDP-145] feat add logo management #21

merged 50 commits into from
Oct 16, 2023

Conversation

alessio-cialini
Copy link
Collaborator

List of Changes

  • Introducing logo management through map, defined through environment variable
  • Introducing placeholder value for env BRAND_LOGO_MAP in the helm chart dev values

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@alessio-cialini alessio-cialini marked this pull request as ready for review October 4, 2023 13:09
@pasqualespica pasqualespica temporarily deployed to uat October 11, 2023 08:48 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to uat October 11, 2023 08:55 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to uat October 11, 2023 09:09 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to uat October 11, 2023 09:10 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to uat October 11, 2023 09:12 — with GitHub Actions Inactive
@jacopocarlini jacopocarlini mentioned this pull request Oct 11, 2023
Closed
5 tasks
@pasqualespica pasqualespica temporarily deployed to uat October 16, 2023 13:45 — with GitHub Actions Inactive
@pasqualespica pasqualespica force-pushed the PRDP-145-feat-add-logo-management branch from 2a9f407 to c0b6508 Compare October 16, 2023 13:47
@pasqualespica pasqualespica temporarily deployed to uat October 16, 2023 13:48 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to uat October 16, 2023 13:48 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to uat October 16, 2023 13:52 — with GitHub Actions Inactive
@pasqualespica pasqualespica force-pushed the PRDP-145-feat-add-logo-management branch from 51406eb to 45aaec6 Compare October 16, 2023 13:53
@pasqualespica pasqualespica force-pushed the PRDP-145-feat-add-logo-management branch from 7641e6a to 83fa3e5 Compare October 16, 2023 21:38
@github-actions
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

59.5% 59.5% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@pasqualespica pasqualespica merged commit bc4a79c into main Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-cialini alessio-cialini

Labels
patch size/large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio-cialini @pasqualespica @alexyey @pagopa-github-bot