Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Changed psp name mapping #56

Merged
merged 3 commits into from
Oct 23, 2023
Merged

[chore] Changed psp name mapping #56

merged 3 commits into from
Oct 23, 2023

Conversation

svariant
Copy link
Collaborator

@svariant svariant commented Oct 23, 2023 •
edited
Loading

List of Changes

  • Changed psp name mapping from BizEvent.psp.name to info in config map
  • Updated unit tests
  • Fixed a duplicate error in GenerateReceiptPdfServiceImplTest caused by a precedent merge

Motivation and Context

Changed the requirement

How Has This Been Tested?

Updated unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@svariant svariant added the patch label Oct 23, 2023
@github-actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@pasqualespica pasqualespica merged commit 261b19f into main Oct 23, 2023
15 of 20 checks passed
@pasqualespica pasqualespica temporarily deployed to dev October 23, 2023 19:47 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to dev October 23, 2023 19:53 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@svariant svariant

Labels
patch size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svariant @pasqualespica