Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRDP-178] Added onboardingChannel info to template #58

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

svariant
Copy link
Collaborator

List of Changes

  • Added boolean to template mapping that indicates if the payment went through PagoPA channels
  • Updated unit tests

Motivation and Context

Issue PRDP-178
Boolean needed to hide psp logo when payment didn't came through PagoPA channels (IO / IO-PAY)

How Has This Been Tested?

Updated and run unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

94.1% 94.1% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍

@pasqualespica pasqualespica merged commit 5918543 into main Oct 24, 2023
9 of 12 checks passed
@pasqualespica pasqualespica temporarily deployed to dev October 24, 2023 09:57 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to dev October 24, 2023 10:03 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants