Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PPANTT-223] feat: Add FdR QI KPI sub key #753

Merged
merged 6 commits into from
Dec 19, 2024
Merged

[PPANTT-223] feat: Add FdR QI KPI sub key #753

merged 6 commits into from
Dec 19, 2024
+47 −14

Conversation

svariant
Copy link
Collaborator

@svariant svariant commented Dec 17, 2024 •
edited
Loading

List of Changes

  • Added new subscription for FdR QI KPI APIM product
  • updated unit tests
  • improved deploy's GHAs adding feature flag to the action inputs

Motivation and Context

PPANTT-223

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@svariant svariant added the minor label Dec 17, 2024
@svariant svariant marked this pull request as ready for review December 17, 2024 15:00
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-island-050778e03-753.westeurope.5.azurestaticapps.net

2 similar comments
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-island-050778e03-753.westeurope.5.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-island-050778e03-753.westeurope.5.azurestaticapps.net

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-island-050778e03-753.westeurope.5.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-island-050778e03-753.westeurope.5.azurestaticapps.net

@gioelemella gioelemella changed the base branch from main to next December 19, 2024 11:45
gioelemella
gioelemella approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@gioelemella gioelemella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-island-050778e03-753.westeurope.5.azurestaticapps.net

@gioelemella gioelemella merged commit d8f39c4 into next Dec 19, 2024
9 of 10 checks passed
@github-actions github-actions bot deleted the PPANTT-223-new-fdr-kpi-api-sub-key branch December 19, 2024 13:23
gioelemella added a commit that referenced this pull request Dec 19, 2024
@gioelemella @alessio-cialini
@pagopa-github-bot @svariant
Next Release 1.40.0 (#754)
2799cb2 
* Bump to version 1.35.4-1-next

* [PPANTT-55] feat: Rework getInstitutions (#701)

* [PPANTT-55] feat: reworked party management

* [PPANTT-55] feat: reworked party management with label

* [PPANTT-55] feat: Align mocks with new Party structure

* [PPANTT-55] fix: PSP role label

* [PPANTT-55] fix: App build

* [PPANTT-55] fix: Unit tests

* [PPANTT-55] fix: Coverage

---------

Co-authored-by: Alessio Cialini <alessio.cialini@emeal.nttdata.com>

* Bump to version 1.36.1-1-next

* Bump to version 1.36.2-1-next [skip ci]

* chore: Unit test for coverage

* chore: Remove MyHeaderProduct from coverage

* Bump to version 1.38.1-1-next [skip ci]

* Bump to version 1.39.3-1-next [skip ci]

* [PPANTT-223] feat: Add FdR QI KPI sub key (#753)

* [PPANTT-223] feat: Add new api key QI_FDR_KPI

* [PPANTT-223] chore: Update packagejson

* [PPANTT-223] fix: Spacing alert api key page

* [PPANTT-223] feat: feature env for api key QI_FDR_KPI

* [PPANTT-223] feat: Improve deploy GHAs with flag switch inputs

* Bump to version 1.39.7-1-next

* feat: Activate QI_KPI apikey in UAT

---------

Co-authored-by: Alessio Cialini <63233981+alessio-cialini@users.noreply.github.com>
Co-authored-by: pagopa-github-bot <github-bot@pagopa.it>
Co-authored-by: svariant <samuele.varianti@nttdata.com>
Co-authored-by: Samuele Varianti <128470180+svariant@users.noreply.github.com>
Co-authored-by: Alessio Cialini <alessio.cialini@emeal.nttdata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioelemella gioelemella gioelemella approved these changes

@alessio-cialini alessio-cialini Awaiting requested review from alessio-cialini alessio-cialini is a code owner

Assignees

@svariant svariant

Labels
minor size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svariant @gioelemella