Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-5665] feat: enable addition Roles using phasesAdditionAllowed #510

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented Oct 1, 2024

List of Changes

  • Added phasesAdditionAllowed to Product object on product-sdk
  • Create a new class ProductUtils which has method validRoles and validRolesByProductRole
  • Replace legacy check of validRole with new one retrieving validRole using phasesAdditionAllowed "onboarding"

Motivation and Context

This PR aims to enable addition of roles during onboarding process using the config property phasesAdditionAllowed. It indicate the phases (onboarding, dashboard, dashboard-async) where adding a Selfcare role is permitted. In onboarding-ms only the roles with "onboarding" phase are permitted. This new logic replace a legacy check based on hardcoded list of [MANAGER,DELEGATE]

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@manuraf manuraf requested a review from a team as a code owner October 1, 2024 08:10
@github-actions github-actions bot added functions Changes are related to functions onboarding-ms libs labels Oct 1, 2024
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@manuraf manuraf merged commit ab415ef into main Oct 1, 2024
14 of 16 checks passed
@manuraf manuraf deleted the feature/SELC-5665 branch October 1, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions Changes are related to functions libs onboarding-ms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant