Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow Box.decrypt to get passed a nonce parameter #135

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

allow Box.decrypt to get passed a nonce parameter #135

wants to merge 7 commits into from

Conversation

bdargan
Copy link

@bdargan bdargan commented Nov 5, 2018

Needed Box.decrypt to handle a nonce buffer.

also includes the Nan to fix #124 (comment)

@paixaop
Copy link
Owner

paixaop commented Nov 14, 2018

@bdargan thanks for the pull request. The Box.encrypt method returns a cypher box which includes the nonce already therefore no need to include it as an extra parameter.
What's the use case?

@bdargan
Copy link
Author

bdargan commented Feb 28, 2019

Main use case is to encrypt and serialize a Box and then deserialize and decrypt it, this requires the original nonce
.
Also there is inconsistency with docs and method signature on Box.decrypt. 2nd param described as a nonce, but this is not on the method signature.

thx

@rawr51919
Copy link

@bdargan Can you please fix the conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing with node 6.12.0
4 participants