Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resources/server.xml
and the same file in theapache-tomcat
buildpack.includes stylistic changes (e.g. changing from
"
to'
for quoting), but also some read-only fs related changes like switching the logging directory to the tmp dir (directory='${java.io.tmpdir}/logs'
)resources/logging.properties
Use Cases
Fixes #107 Note: this issue also mentions the lifecycle helper, which IMHO is unrelated to the issue and should be moved into a separate issue.
Checklist