Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent logging to files #113

Merged

Conversation

phil9909
Copy link
Member

Summary

  • minimize diff between resources/server.xml and the same file in the apache-tomcat buildpack.
    includes stylistic changes (e.g. changing from " to ' for quoting), but also some read-only fs related changes like switching the logging directory to the tmp dir (directory='${java.io.tmpdir}/logs')
  • Remove any non console loggers from resources/logging.properties
  • Improve integration test: actually verify access logs are written.

Use Cases

Fixes #107 Note: this issue also mentions the lifecycle helper, which IMHO is unrelated to the issue and should be moved into a separate issue.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@phil9909 phil9909 requested a review from a team November 28, 2022 12:47
@phil9909 phil9909 mentioned this pull request Nov 28, 2022
@dmikusa dmikusa added semver:patch A change requiring a patch version bump type:task A general task labels Dec 9, 2022
@dmikusa
Copy link
Contributor

dmikusa commented Dec 9, 2022

This all looks good, the branch is out of date. If you can update this PR (merge or rebase main), then we'll be all set. Thanks!

Co-authored-by: Philipp Stehle <philipp.stehle@sap.com>
Co-authored-by: Pavel Busko <pavel.busko@sap.com>
@phil9909
Copy link
Member Author

phil9909 commented Dec 9, 2022

This all looks good, the branch is out of date. If you can update this PR (merge or rebase main), then we'll be all set. Thanks!

Done

@dmikusa dmikusa merged commit 433e059 into paketo-buildpacks:main Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console logging
3 participants