Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TomEE Detection Logic #59

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Fix TomEE Detection Logic #59

merged 3 commits into from
Aug 17, 2022

Conversation

modulo11
Copy link
Contributor

Summary

Fixes #22 and replaces some deprecated API calls.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@modulo11 modulo11 requested a review from a team August 15, 2022 10:13
dmikusa
dmikusa approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@dmikusa dmikusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks fantastic.

@dmikusa dmikusa added semver:patch A change requiring a patch version bump type:bug A general bug labels Aug 16, 2022
@dmikusa
Copy link
Contributor

dmikusa commented Aug 16, 2022

Github is saying This branch is out-of-date with the base branch, but it's not giving me the option to update your branch for some reason. Apologies, I'm usually able to do that. Are you able to update the branch through the UI, or git rebase your branch from origin/main and force push it back up? When it's current, I can merge it in.

@modulo11
Copy link
Contributor Author

Hi @dmikusa-pivotal,
no issues, I rebased the branch manually.

@dmikusa dmikusa merged commit e4fe6e2 into paketo-buildpacks:main Aug 17, 2022
@modulo11 modulo11 deleted the fix-22 branch August 17, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmikusa dmikusa dmikusa approved these changes

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tomee detect logic misses case where it's first and no server is set
2 participants
@modulo11 @dmikusa