Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile multi arch support for push-image workflow #984

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Oct 8, 2024

Summary

This PR reconciles the implementation of push-image workflow for a single architecture with the multi-arch one that currently exists on jammy-tiny-stack.

In addition to push-image.yml changes, this PR adds an extra script called publish.sh, which pushes the images to the registry. The publish.sh is based on the multiarch implementation script that exists on jammy-tiny-stack https://github.com/paketo-buildpacks/jammy-tiny-stack/blob/main/scripts/publish.sh and in addition extra functionality has been added, to push one image per time instead of two images per time, as jam now supports this feature paketo-buildpacks/jam#346 . The default functionality of the publis.sh script has not been changed.

This PR has been tested that pushes the images properly to the registries. Test results :

This PR does not change any of the current functionality of the stacks while pushing to registry. It only adds new functionality which enables single and multi arch implementation to publish their images.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas marked this pull request as ready for review November 1, 2024 10:49
@pacostas pacostas requested a review from a team as a code owner November 1, 2024 10:49
@pacostas
Copy link
Contributor Author

pacostas commented Nov 1, 2024

@ForestEckhardt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant