-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to provide a custom gradle.properties file #60
Conversation
When a binding of type or kind equals `gradle` is present, the contents of that file are copied to `$GRADLE_USER_HOME/gradle.properties`. This is picked up by Gradle when it runs and allows the user to pass additional configuration to Gradle. For example, this can be used for providing credentials to a remote Maven repository.
A couple of notes on this PR:
|
This is based on the work added with paketo-buildpacks/gradle#60, so requires a version of the Gradle CNB with this feature.
…d of copying it into the layer
This is based on the work added with paketo-buildpacks/gradle#60, so requires a version of the Gradle CNB with this feature.
Co-authored-by: Emily Casey <ecasey@vmware.com>
…r to the layer where gradle runs, but after the cache layer. This allows the cache code to run and initialize the symlink for the cache, then this layer contributes next, adding the symlink into the cache directory and finally gradle runs.
I think we need to add a hash of the properties file to the application layer metadata. Right now a change to the properties file won't trigger a rebuild of the app layer. |
I added this. It stores the sha256 hash of the properties into the metadata now, similar to what we do in the maven cnb with settings.xml. |
Summary
When a binding of type or kind equals
gradle
is present, the contents of that file are copied to$GRADLE_USER_HOME/gradle.properties
. This is picked up by Gradle when it runs and allows the user to pass additional configuration to Gradle. For example, this can be used for providing credentials to a remote Maven repository.Use Cases
Resolves #23
Checklist