Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JRE/JDKs to be installed from alternative archives (e.g. .zip) #155

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

garethjevans
Copy link
Contributor

@garethjevans garethjevans commented Mar 21, 2022

Summary

The SAPJVM JRE is distributed as .zip rather than .tar.gz file, we'd like to be able to utilise libjvm to be able to install this.

Use Cases

Original PR was #149, the Extract functionality has been updated in libpak

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@garethjevans garethjevans requested a review from a team March 21, 2022 07:18
go.mod Outdated Show resolved Hide resolved
@garethjevans
Copy link
Contributor Author

@dmikusa-pivotal I think is ready

@dmikusa dmikusa added semver:minor A change requiring a minor version bump type:enhancement A general enhancement labels Mar 22, 2022
@dmikusa dmikusa merged commit 35338e3 into paketo-buildpacks:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants