Reproducible Certificates #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the way certificates were created was non-reproducible. A "current" timestamp was used when adding entries to the trust store which would mean that the keystore would be unique each time it was created. This change uses our standard normalized timestamp during creation. Signed-off-by: Ben Hale <bhale@vmware.com>
nebhale
added
semver:patch
ekcasey
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the way certificates were created was non-reproducible. A "current" timestamp was used when adding entries to the trust store which would mean that the keystore would be unique each time it was created. This change uses our standard normalized timestamp during creation.
Note that this isn't the full solution and requires pavlo-v-chernykh/keystore-go#23 to solve the problem completely. However, I don't think this should wait for that fix because
[paketo-buildpacks/builder#45]