Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves carton package in from libpak #58

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Moves carton package in from libpak #58

merged 2 commits into from
Oct 30, 2024

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Oct 29, 2024

Summary

Updates references to use now public packages in libpak, like utils and testing.

This requires paketo-buildpacks/libpak#373 to be merged & released.

Updates references to use now public packages in libpak, like utils and testing.

Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa dmikusa requested a review from a team as a code owner October 29, 2024 02:52
@dmikusa dmikusa added type:enhancement A general enhancement semver:major A change requiring a major version bump labels Oct 29, 2024
@anthonydahanne
Copy link
Member

@dmikusa the tests don't seem to run...
have you tried to run go mod tidy ?

This is required because of changes that were made to libpak

Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa
Copy link
Contributor Author

dmikusa commented Oct 30, 2024

It needed paketo-buildpacks/libpak#373. I just merged that and updated go.mod to reference the latest commit of the v2 branch, so all is good now.

@dmikusa dmikusa merged commit b0ca61d into main Oct 30, 2024
4 checks passed
@dmikusa dmikusa deleted the cmd-cleanup branch October 30, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:major A change requiring a major version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants