Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add customizable timeout settings for the HTTP Client #250

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Add customizable timeout settings for the HTTP Client #250

merged 1 commit into from
Jun 5, 2023

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Jun 5, 2023

Summary

Adds customizable timeout settings to the HTTP client.

Use Cases

Superceeds #236

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa
Add customizable timeout settings for the HTTP Client
45f8e75 
Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa dmikusa added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Jun 5, 2023
@dmikusa dmikusa requested a review from a team as a code owner June 5, 2023 13:04
@dmikusa dmikusa mentioned this pull request Jun 5, 2023
Closed
5 tasks
@anthonydahanne
Copy link
Member

anthonydahanne commented Jun 5, 2023 •
edited
Loading

The changes to default values are:

  • dialerTimeout: from none to 6s.
  • dialerKeepAlive from 15 seconds to 60s
  • tlsHandshakeTimeout from none to 5s
  • responseHeaderTimeout from none to 5s
  • expectContinueTimeout from none to 1s

@dmikusa dmikusa merged commit e128f3b into main Jun 5, 2023
@dmikusa dmikusa deleted the http-timeouts branch June 5, 2023 19:24
@ForestEckhardt ForestEckhardt mentioned this pull request Jun 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonydahanne anthonydahanne anthonydahanne approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmikusa @anthonydahanne