Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for architecture selection during updating of buildpack dependencies #306

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Jan 19, 2024

Summary

The update-buildpack-dependency too doesn't match correctly with the introduction of dependency architectures. This includes architecture as a consideration when filtering the dependencies to pick what is updated. A dependency now needs to match both the ID and ARCH.

This is presently pulling the architecture from the PURL as it's the only currently reliable spot to get it. In the future, when all of the buildpacks have switched to it, we should pull from the arch field.

Use Cases

Multi-arch support.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

…ependencies

Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Jan 19, 2024
@dmikusa dmikusa requested a review from a team as a code owner January 19, 2024 04:32
Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa dmikusa merged commit 931aaf5 into main Jan 19, 2024
6 checks passed
@dmikusa dmikusa deleted the arch-support branch January 19, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant