Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hostname specific dependency mirrors #322

Merged
merged 8 commits into from
Apr 12, 2024

Conversation

bitgully
Copy link
Contributor

@bitgully bitgully commented Apr 2, 2024

Summary

Enhances the use of dependency mirrors introduced in #315.
Changes have been applied according to the conversation in paketo-buildpacks/rfcs#302 (Readable).

This change allows for setting separate mirror locations for each hostname in the dependencies' original URIs.
A default mirror can still be used for all other dependencies.

Use Cases

This is required in networks where not all dependencies should be pulled from the same mirror location.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa dmikusa added type:task A general task semver:patch A change requiring a patch version bump labels Apr 4, 2024
@dmikusa
Copy link
Contributor

dmikusa commented Apr 4, 2024

Thanks for this PR. I added some thoughts/questions. Let me know what you think.

@bitgully
Copy link
Contributor Author

@dmikusa Would you agree with my responses or do you think this needs more attention?
Any specific ideas how we should go about adding this to packit?

@loewenstein
Copy link

Any specific ideas how we should go about adding this to packit?

I think that is already in progress with paketo-buildpacks/packit#563

@dmikusa
Copy link
Contributor

dmikusa commented Apr 12, 2024

Sorry for the delay. I think this is looking good. Just one last question for you.

Thanks again for your work on this!

@dmikusa dmikusa merged commit 99fe914 into paketo-buildpacks:main Apr 12, 2024
4 checks passed
dmikusa added a commit that referenced this pull request Nov 12, 2024
Signed-off-by: Daniel Mikusa <dan@mikusa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants