Add Maven 4 #212
Merged
Add Maven 4 #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds Maven 4 (alpha). This is added as a second major branch for anyone that is interested in trying it. It also adds the ability to select the major version of Maven that is used. The default version is set to version 3.x. By setting `BP_MAVEN_VERSION`, you can override this. This also includes a minor fix where the logger was not being plumbed through to the Maven Manager object. That could have resulted in loss of some log events. Signed-off-by: Daniel Mikusa <dan@mikusa.com>
dmikusa
added
semver:minor
pivotal-david-osullivan
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Maven 4 (alpha). This is added as a second major branch for anyone that is interested in trying it.
It also adds the ability to select the major version of Maven that is used. The default version is set to version 3.x. By setting
BP_MAVEN_VERSION, you can override this.This also includes a minor fix where the logger was not being plumbed through to the Maven Manager object. That could have resulted in loss of some log events.
While this adds everything to support Maven 4, the update job for Maven 4 isn't going to work until this pipeline-builder request is merged. It does not require a new pipeline-builder version, as the changes required are only in the maven dependency action and that is not versioned.
Resolved #204
Use Cases
Try using Maven 4.