Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use the full path in generated process types #220

Closed
dmikusa opened this issue Jan 6, 2023 · 0 comments
Closed

Do not use the full path in generated process types #220

dmikusa opened this issue Jan 6, 2023 · 0 comments
Labels
hacktoberfest Hacktoberfest eligible note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:enhancement A general enhancement

Comments

@dmikusa
Copy link
Contributor

dmikusa commented Jan 6, 2023

Describe the Enhancement

When the buildpack runs, it generates process types to run the native-image executables. It generates a full path like /workspace/my-super-cool-app. Instead, we should use ./my-super-cool-app. The app will be executed from the application workspace so it's not necessary to prefix the path.

Possible Solution

Modify build.go to generate different commands.

Motivation

This is not presently a problem, but theoretically, the /workspace or application directory can change between the build and export phase. So the platform could provide /workspace at build time and /app during export, so the image is generated with /app. That would obviously break the commands generated because they hardcode in the full path.

We're not seeing any platforms that do this presently, but this would be a minor change to make the buildpacks more flexible.

@dmikusa dmikusa added type:enhancement A general enhancement note:ideal-for-contribution An issue that a contributor can help us with note:good-first-issue A good first issue to get started with labels Jan 6, 2023
anthonydahanne added a commit to anthonydahanne/native-image that referenced this issue Mar 7, 2023
anthonydahanne added a commit to anthonydahanne/native-image that referenced this issue Mar 10, 2023
Co-authored-by: Daniel Mikusa <dan@mikusa.com>
anthonydahanne added a commit to anthonydahanne/native-image that referenced this issue Mar 10, 2023
anthonydahanne added a commit to anthonydahanne/native-image that referenced this issue Mar 10, 2023
Co-authored-by: Daniel Mikusa <dan@mikusa.com>
anthonydahanne added a commit to anthonydahanne/native-image that referenced this issue Mar 10, 2023
Co-authored-by: Daniel Mikusa <dan@mikusa.com>
dmikusa added a commit that referenced this issue Mar 10, 2023
@anthonydahanne anthonydahanne added the hacktoberfest Hacktoberfest eligible label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest eligible note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants