Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error during detection if value of BP_NATIVE_IMAGE is not parseable #61

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

ekcasey
Copy link
Member

@ekcasey ekcasey commented Mar 31, 2021

Print an error during detection if BP_NATIVE_IMAGE is not one of 1, t, T, TRUE, true, True, 0, f, F, FALSE, false, or False

Signed-off-by: Emily Casey <ecasey@vmware.com>
@ekcasey ekcasey added semver:patch A change requiring a patch version bump type:bug A general bug labels Mar 31, 2021
@ekcasey ekcasey requested a review from a team March 31, 2021 13:26
@ekcasey ekcasey merged commit 625cdc3 into main Mar 31, 2021
@ekcasey ekcasey deleted the bugfix/parse-error branch March 31, 2021 13:27
ekcasey added a commit that referenced this pull request Mar 31, 2021
Fixes mistake from #61 and adds a test for the case where BP_NATIVE_IMAGE is not a parseable bool

Signed-off-by: Emily Casey <ecasey@vmware.com>
ekcasey added a commit that referenced this pull request Mar 31, 2021
Fixes mistake from #61 and adds a test for the case where BP_NATIVE_IMAGE is not a parseable bool

Signed-off-by: Emily Casey <ecasey@vmware.com>
ekcasey added a commit that referenced this pull request Mar 31, 2021
Fixes mistake from #61 and adds a test for the case where BP_NATIVE_IMAGE is not a parseable bool

Signed-off-by: Emily Casey <ecasey@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant