Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring should not be required when using Native Image buildpack #67

Merged
merged 1 commit into from
May 13, 2021
Merged

Spring should not be required when using Native Image buildpack #67

merged 1 commit into from
May 13, 2021

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented May 13, 2021

Summary

Presently there is a guard which requires Spring Boot when using the Native Image buildpack. This shouldn't be required.

Use Cases

Resolves #66

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa dmikusa requested a review from a team May 13, 2021 20:57
@dmikusa dmikusa added semver:patch A change requiring a patch version bump type:bug A general bug labels May 13, 2021
@dmikusa dmikusa merged commit f4ba321 into main May 13, 2021
@dmikusa dmikusa deleted the gh_issue_66 branch May 13, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't Work With Non-Spring Apps
1 participant
@dmikusa