Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding ubi-buildpackless-base builder on integration tests #386

Conversation

pacostas
Copy link
Contributor

Summary

The goal of this change, is to guarantee that all node-start integration tests run against ubi-buildpackless-base builder. This is very important as we ensure that node-start buildpack is able to collaborate with ubi-buidpackless-base builder in conjunction with ubi-nodejs-extension in the present and in any upcoming fixes/features.

Use Cases

This PR adds ubi-buildpackless-base builder on integration tests, more specifically:

  • For each integration test we are able to use the ubi-buildpackless-base builder in conjunction with ubi-nodejs-extension
  • Each time the ubi-biuldpackless-base is available, then on the pack.build command the ubi-nodejs-extension is being included otherwise not. That way, we are able to add the ubi-nodejs-extension only when the ubi-buildpackless-base is present.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner September 28, 2023 12:58
@thitch97
Copy link
Contributor

@pacostas I think you'll have to enable the experimental pack features for the integration tests to pass

@pacostas
Copy link
Contributor Author

@thitch97 added it, can you retrigger them?

@thitch97 thitch97 added the semver:patch A change requiring a patch version bump label Oct 26, 2023
@thitch97 thitch97 merged commit fdcf4e6 into paketo-buildpacks:main Oct 26, 2023
10 of 11 checks passed
@pacostas pacostas deleted the ubi-buildpackless-base-integration-tests branch October 26, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants