Skip to content

Commit

Permalink
Buildpack packaging should always target linux
Browse files Browse the repository at this point in the history
  • Loading branch information
ForestEckhardt authored and sophiewigmore committed Jun 10, 2024
1 parent 7b8692d commit aff3030
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion packagers/jam.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func (j Jam) Execute(buildpackDir, output, version string, offline bool) error {
output,
"--path", buildpackTarballPath,
"--format", "file",
"--target", fmt.Sprintf("%s/%s", runtime.GOOS, runtime.GOARCH),
"--target", fmt.Sprintf("linux/%s", runtime.GOARCH),
}

return j.pack.Execute(pexec.Execution{
Expand Down
6 changes: 3 additions & 3 deletions packagers/jam_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func testJam(t *testing.T, context spec.G, it spec.S) {
"some-output",
"--path", filepath.Join("some-jam-output", "some-version.tgz"),
"--format", "file",
"--target", fmt.Sprintf("%s/%s", runtime.GOOS, runtime.GOARCH),
"--target", fmt.Sprintf("linux/%s", runtime.GOARCH),
}))
})

Expand All @@ -77,7 +77,7 @@ func testJam(t *testing.T, context spec.G, it spec.S) {
"some-output",
"--path", filepath.Join("some-jam-output", "some-version.tgz"),
"--format", "file",
"--target", fmt.Sprintf("%s/%s", runtime.GOOS, runtime.GOARCH),
"--target", fmt.Sprintf("linux/%s", runtime.GOARCH),
}))
})
})
Expand Down Expand Up @@ -115,7 +115,7 @@ func testJam(t *testing.T, context spec.G, it spec.S) {
"some-output",
"--path", filepath.Join("some-jam-output", "some-version.tgz"),
"--format", "file",
"--target", fmt.Sprintf("%s/%s", runtime.GOOS, runtime.GOARCH),
"--target", fmt.Sprintf("linux/%s", runtime.GOARCH),
}))
})
})
Expand Down
2 changes: 1 addition & 1 deletion packagers/libpak.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func (l Libpak) Execute(buildpackDir, output, version string, cached bool) error
output,
"--path", libpakOutput,
"--format", "file",
"--target", fmt.Sprintf("%s/%s", runtime.GOOS, runtime.GOARCH),
"--target", fmt.Sprintf("linux/%s", runtime.GOARCH),
}

return l.pack.Execute(pexec.Execution{
Expand Down
4 changes: 2 additions & 2 deletions packagers/libpak_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func testLibpak(t *testing.T, context spec.G, it spec.S) {
"some-output-dir",
"--path", "some-libpak-output-dir",
"--format", "file",
"--target", fmt.Sprintf("%s/%s", runtime.GOOS, runtime.GOARCH),
"--target", fmt.Sprintf("linux/%s", runtime.GOARCH),
}))
})

Expand All @@ -72,7 +72,7 @@ func testLibpak(t *testing.T, context spec.G, it spec.S) {
"some-output-dir",
"--path", "some-libpak-output-dir",
"--format", "file",
"--target", fmt.Sprintf("%s/%s", runtime.GOOS, runtime.GOARCH),
"--target", fmt.Sprintf("linux/%s", runtime.GOARCH),
}))
})
})
Expand Down

0 comments on commit aff3030

Please sign in to comment.