Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds strip-components option to tar archives #10

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Conversation

ForestEckhardt
Copy link
Contributor

Purposed interface for strip-component option on for tar archives.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/172182003

The labels on this github issue will be updated when the story is started.

@ryanmoran
Copy link
Member

Why do we need this? I thought we were trying to get archives that didn't have these superfluous directories.

@ForestEckhardt ForestEckhardt requested review from dwillist and ryanmoran and removed request for ryanmoran and dwillist April 10, 2020 19:34
@ForestEckhardt
Copy link
Contributor Author

ForestEckhardt commented Apr 10, 2020

@ryanmoran I agree that this is true for the cnbs but I have been trying to use this package in other projects and the inability to do this when the tar command allows me is frustrating. It may also be beneficial to people using this library that do not have strong control over their artifacts. My goal with this interface was to keep the default behavior what we are expecting but allow for expansion.

Some examples of where I am using this and it might be helpful is freezer, and I will be using it in further expansion of the buildpack tutorial but would still like to use the artifact that is downloaded from node which requires me to strip components.

Copy link
Member

@ryanmoran ryanmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I really like that the StripComponents feature is added as an "option" so that the primary API remains untouched. 👏

@ryanmoran ryanmoran merged commit fecca40 into master Apr 17, 2020
@ryanmoran ryanmoran deleted the strip-components branch April 17, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants