-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency mappings #119
Dependency mappings #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is implemented, DependencyMappingResolver
has become part of the public API for postal
. Do we have a usecase that justifies exposing it as part of the public API, or should we make it private? If it can be justified as a useful part of the public API, then I'd like to see documentation included in the code like we have for the other public types and functions:
Lines 36 to 43 in e6b39a5
// Resolve will pick the best matching dependency given a path to a | |
// buildpack.toml file, and the id, version, and stack value of a dependency. | |
// The version value is treated as a SemVer constraint and will pick the | |
// version that matches that constraint best. If the version is given as | |
// "default", the default version for the dependency with the given id will be | |
// used. If there is no default version for that dependency, a wildcard | |
// constraint will be used. | |
func (s Service) Resolve(path, id, version, stack string) (Dependency, error) { |
@fg-j @ForestEckhardt Can you rebase this off |
- This might not be the best solution - Need to figure out how to fake out the /platform/binding path
d6bbe27
to
462ab8a
Compare
to avoid changing Service constructor and Install() interfaces Signed-off-by: Forest Eckhardt <feckhardt@pivotal.io>
Signed-off-by: Forest Eckhardt <feckhardt@pivotal.io>
Signed-off-by: Forest Eckhardt <feckhardt@pivotal.io>
Signed-off-by: Forest Eckhardt <feckhardt@pivotal.io>
462ab8a
to
18c6450
Compare
I don't know what happened in the original rebase, but this ended up weirdly including |
Summary
Adds the ability to look for dependency mappings in bindings. Notably, doesn't change the interface of the postal Service to avoid disrupting existing buildpacks. The interface will likely change once we fully implement Service Bindings support.
Resolves #106
Use Cases
Checklist