Add support for supplying strip-components via buildpack.toml #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samj1912 Besides that one nitpick comment I left, this looks great! I tried it locally and it works as expected. Cheers |
This PR adds a strip-components flag to postal’s service resolver. So that when it parses the buildpack tomls it can use artifacts that are tar’d in a slightly different manner. This would allow for customization of paketo forks that only have a different buildpack.toml. For more details see https://paketobuildpacks.slack.com/archives/CULAS8ACD/p1619441959093300 Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
sophiewigmore
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a strip-components flag to postal’s service resolver. So that when it parses the buildpack tomls it can use artifacts that are tar’d in a slightly different manner. This would allow for customization of paketo forks that only have a different buildpack.toml.
For more details see https://paketobuildpacks.slack.com/archives/CULAS8ACD/p1619441959093300
Signed-off-by: Sambhav Kothari skothari44@bloomberg.net
Checklist